Replace Array.GetLength on single-dimensional arrays with Length property #9334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
PR
hiteshkrmsft
reviewed
Jul 2, 2024
src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Media/Color.cs
Show resolved
Hide resolved
hiteshkrmsft
reviewed
Jul 2, 2024
src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Media/Imaging/WriteableBitmap.cs
Outdated
Show resolved
Hide resolved
…plicitly for optimal performance
hiteshkrmsft
approved these changes
Jul 3, 2024
dipeshmsft
approved these changes
Aug 27, 2024
dipeshmsft
added
Included in test pass
and removed
Queue for test pass
Status:Committed
labels
Member
|
@h3xds1nz Thank you for your contributions. |
Member
Author
|
@harshit7962 Thanks for including them. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces
Array.GetLength(0)on single-dimensional arrays with theLengthproperty for performance benefit, clarity and general code quality. I didn't replace a few inColorandColorTransformas that's part of my other PR and I don't want to create conflicts.Customer Impact
Improved performance.
Regression
No.
Testing
Build, the changes are minimal hence no further testing.
Risk
Low.
Microsoft Reviewers: Open in CodeFlow