Skip to content

Making common resource in parity with WinUI #9421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 17, 2024
Merged

Making common resource in parity with WinUI #9421

merged 2 commits into from
Jul 17, 2024
+42 −137

Conversation

@himgoyalmicro
Copy link
Contributor

@himgoyalmicro himgoyalmicro commented Jul 17, 2024 •
edited by dotnet-policy-service bot
Loading

Description

To make the colors and brushes more alinged with the WinUI one we have made the following changes:

  1. Added some brushes in Light.xaml and dark.xaml
  2. Changed the color code of TextOnAccentFillColorDisabled and ControlAltFillColorTertiary in Light.xaml and dark.xaml
  3. Removed some brushes from Light.xaml, HC.xaml and dark.xaml

Regression

None

Testing

Local build passed, tested sample app.

Risk

NA

Microsoft Reviewers: Open in CodeFlow

@himgoyalmicro himgoyalmicro self-assigned this Jul 17, 2024
@himgoyalmicro himgoyalmicro requested review from a team as code owners July 17, 2024 11:34
@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label Jul 17, 2024
@dipeshmsft dipeshmsft merged commit 8529feb into dotnet:main Jul 17, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dipeshmsft dipeshmsft dipeshmsft approved these changes

@singhashish-wpf singhashish-wpf Awaiting requested review from singhashish-wpf

Assignees

@himgoyalmicro himgoyalmicro

Labels

PR metadata: Label to tag PRs, to facilitate with triage Win 11 Theming

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@himgoyalmicro @dipeshmsft