Debug::Assert(false to Debug::Fail #9441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
PR
333fred
reviewed
Jul 22, 2024
src/Microsoft.DotNet.Wpf/src/System.Printing/CPP/src/GDIExporter/gdibitmap.cpp
Show resolved
Hide resolved
stephentoub
approved these changes
Jul 23, 2024
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
I ran a test build of this change on dotnet/dotnet#101 and it fixes the issue so this is ready to be merged. |
anjaligupta-dev
approved these changes
Jul 23, 2024
anjaligupta-dev
left a comment
anjaligupta-dev
left a comment
There was a problem hiding this comment.
Thanks @kasperk81 and @akoeplinger
|
/backport to release/9.0-preview7 |
|
Started backporting to release/9.0-preview7: https://github.com/dotnet/wpf/actions/runs/10057120938 |
Contributor
|
/backport to release/9.0-preview7 |
|
Started backporting to release/9.0-preview7: https://github.com/dotnet/wpf/actions/runs/10057138438 |
pchaurasia14
added a commit
to pchaurasia14/wpf
that referenced
this pull request
Jul 25, 2024
This reverts commit e84c567.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet/sdk#42262 (comment)
Microsoft Reviewers: Open in CodeFlow