Fixing scrollviewer visibility in textbox #9703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
the
PR
siagupta0202
added
Win 11 Theming
and removed
PR
Member
|
/backport to release/9.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/wpf/actions/runs/10890280913 |
dipeshmsft
approved these changes
Sep 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9197
Description
Fixes visibility of ScrollViewer in TextBox in the new Fluent styles introduced in .NET 9.
In the previous styles ( Aero2 ) when we set the ScrollViewer.HorizontalScrollBarVisibility or ScrollViewer.VerticalScrollBarVisibility on TextBox, scrollbars appear in the TextBox area, however in the new Fluent styles, the properties did not work. This PR fixes the above issue
Regression
Technically no, but any developer who will try to port their application to use the new styles will face this issue and the property won't work for them.
Testing
Local build pass. Tested with sample application.
Risk
NA
Microsoft Reviewers: Open in CodeFlow