[release/9.0] Add missing Bindings in Fluent ControlTemplates #9790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
the
PR
singhashish-wpf
previously approved these changes
Sep 17, 2024
pchaurasia14
approved these changes
Sep 17, 2024
Contributor
|
Approved over email |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #9786 to release/9.0
/cc @dipeshmsft
Fixes #9564
Description
In many of the Fluent styles template bindings are not set correctly. In this PR, I have tried to fix most of the template binding issues by comparing the styles to both Aero2 and WinUI styles.
Customer Impact
Developers using the new Fluent styles won't have to create custom styles for setting properties like BorderBrush, Background, BorderThickness and alignment properties.
Regression
Technically no, but any developer who will try to port their application to use the new styles will face this issue and the properties won't work for them.
Testing
Local testing with sample apps and WPF Gallery application.
Risk
Minimal. Apps are not using this feature ( except those who are working with .NET 9 preview releases )
PS : Breakdown of the PR - Fluent.Light.xaml, Fluent.Dark.xaml and Fluet.HC.xaml are auto generated files and they reflect the changes made in other files. Hence the actual change size if around 1/4th of what appears in the PR
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.Microsoft Reviewers: Open in CodeFlow