Remove AppContextDefaultValues/AccessibilitySwitches values from NetFX (dead code) #9866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
PR
harshit7962
requested changes
Oct 24, 2024
src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/AppContextDefaultValues.cs
Outdated
Show resolved
Hide resolved
dotnet-policy-service
bot
added
📭 waiting-author-feedback
harshit7962
previously approved these changes
Oct 25, 2024
harshit7962
approved these changes
Oct 25, 2024
harshit7962
added
Included in test pass
and removed
Queue for test pass
Included in test pass
Status:Committed
labels
Member
|
@h3xds1nz Thank you for the contribution. |
Member
Author
|
@harshit7962 Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up to #9711, cleaning up the dead code from assemblies that are compiled for .NET Core only.
The PBT one has been kept for obvious reasons.
The effective process is removing the switch statement, values for
NetFXand copying over contents ofInitializeNetFxSwitchDefaultsForNetCoreRuntimedirectly into the partial method.I have also removed the warning supressions where they were not necessary.
Customer Impact
Smaller size of assemblies, 0.0001 ns faster start up time, cleaner codebase for developers.
Regression
No.
Testing
Local build, app startup.
Risk
Low, this is just a cleanup after previous PR.
Microsoft Reviewers: Open in CodeFlow