-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Replace ArrayList in InputProcessorProfiles with fixed-size array, reduce allocations #9946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h3xds1nz
commented
Oct 12, 2024
src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Input/InputProcessorProfiles.cs
Show resolved
Hide resolved
Member
|
LGTM, @h3xds1nz can you please resolve the merge conflict here as well. |
efc79af to
68366c2
Compare
Member
Author
|
@dipeshmsft Done :) |
dipeshmsft
approved these changes
May 16, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9946 +/- ##
===================================================
- Coverage 13.62756% 13.58849% -0.03908%
===================================================
Files 3316 3317 +1
Lines 664822 664754 -68
Branches 74651 74642 -9
===================================================
- Hits 90599 90330 -269
- Misses 571523 571829 +306
+ Partials 2700 2595 -105
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Community Contribution
A label for all community Contributions
Included in test pass
PR
metadata: Label to tag PRs, to facilitate with triage
Status:Completed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Loosely follows #9221, replacing the other part of the
InputLanguageSource.InputLanguageListwith more modern code.ReadOnlySpan<short>.ArrayList, we preallocate the array as we know the final count.Single invocation of the property (without
_ippinit); 5 profilesCustomer Impact
Improved performance, decreased allocations.
Regression
No.
Testing
Local build, testing new output matches the old one.
Risk
Low.
Microsoft Reviewers: Open in CodeFlow