-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Remove array/object allocs during Alt+Numpad composition, improve performance #9954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove array/object allocs during Alt+Numpad composition, improve performance #9954
Conversation
|
@h3xds1nz this PR is good to be merged. Can you please resolve the merge conflicts? |
b7cbb10 to
9879f39
Compare
|
@himgoyalmicro Done :) |
|
Thank you @h3xds1nz for your consistent and valuable contributions. 😄😄 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9954 +/- ##
===================================================
- Coverage 11.28308% 11.21741% -0.06568%
===================================================
Files 3353 3353
Lines 668062 668051 -11
Branches 74980 74980
===================================================
- Hits 75378 74938 -440
- Misses 591433 591867 +434
+ Partials 1251 1246 -5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
@himgoyalmicro Thank you for merging :) |
Description
Removes unnecessary
byte[],char[]andStringBuilderalocations during post-input processing when the char is inputted via Alt+Numpad combination. This is not somewhat impactful allocation but it will allow for more optimizations in the future.Time spent is cut by 2/5 which is more impactful in this case.
GetCurrentOEMCPEncoding method chain call
Customer Impact
Improved performance, decreased allocations.
Regression
No.
Testing
Local build, text input.
Risk
Low.
Microsoft Reviewers: Open in CodeFlow