Separate install and run operations for iOS apps #538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/Microsoft.DotNet.XHarness.Apple/AppRunnerBase.cs tests/Microsoft.DotNet.XHarness.Apple.Tests/AppInstallerTests.cs tests/Microsoft.DotNet.XHarness.Apple.Tests/AppRunnerTests.cs tests/Microsoft.DotNet.XHarness.Apple.Tests/AppTesterTests.cs
Member
Author
|
The new command for launching Simulator app without installing will need a new mlaunch version so the CI will fail before we get it. |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
src/Microsoft.DotNet.XHarness.iOS.Shared/Execution/MlaunchProcessManager.cs
Show resolved
Hide resolved
greenEkatherine
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to introduce the new
install/run-test/uninstallcommands (#493), we need to separate installation from running the app which is currently happening via 1 mlaunch command for Simulators.We unify the approach for Simulators and devices and do the install separately. This will also help with diagnosis of issues when simulators freeze and we don't know at which stage.
The code was refactored out of the
Commandclasses into theOrchestratorclasses so that it can be tested later too.We can also now test passing args to the
Commandsand how they get parsed.