Add Empty HttpTransformer #1444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MihaZupan
reviewed
Dec 13, 2021
| static HttpTransformer() | ||
| { | ||
| Default = TransformBuilder.CreateTransformer(new TransformBuilderContext()); | ||
| Empty = new HttpTransformer(); |
There was a problem hiding this comment.
Can we change this to not use the static ctor? I don't think there's anything preventing these fields from being initialized inline.
|
@Kahbazi thanks for your PR. I was actually working on it as well, that's why I self-assigned, but I forgot to remove the "help wanted" label. I will add a test for this change after it is merged. |
Tratcher
reviewed
Dec 13, 2021
| public static readonly HttpTransformer Default; | ||
|
|
||
| /// <summary> | ||
| /// A default set of transforms that copies all request and response fields and headers, except for some |
There was a problem hiding this comment.
Suggested change
| /// A default set of transforms that copies all request and response fields and headers, except for some | |
| /// An empty transformer that copies all request and response fields and headers, except for some |
Sorry, I didn't notice the Assignees of the issue. |
Tratcher
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1409