Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Feb 22, 2025

revert grid layout

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #5423

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Reverts the grid layout of the ListView component and adjusts the styling to improve the visual presentation.

Bug Fixes:

Enhancements:

  • Improved the styling of the ListView component by adjusting padding and margins for better visual presentation.

@bb-auto bb-auto bot added the enhancement New feature or request label Feb 22, 2025
@bb-auto bb-auto bot added this to the v9.3.0 milestone Feb 22, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 22, 2025

Reviewer's Guide by Sourcery

Reverted the ListView component from a grid layout back to a flex layout to address issue #5423.

Updated class diagram for ListView component

classDiagram
    class ListView {
        -RenderFragment RenderItem
        -RenderFragment RenderGroupItem
    }

    ListView ..> RenderFragment : uses
    note for ListView "RenderGroup removed, RenderItem and RenderGroupItem updated to reflect flex layout"
Loading

File-Level Changes

Change Details Files
Reverted the grid layout implementation for the ListView component, restoring the original flex layout.
  • Replaced the grid layout with a flex layout in the ListView body.
  • Adjusted the styling for list items to use margins instead of gaps.
  • Modified the accordion body to use flex layout for item arrangement.
  • Updated the ListView samples to remove the lv-demo-img class and add a margin to the images.
src/BootstrapBlazor/Components/ListView/ListView.razor
src/BootstrapBlazor/Components/ListView/ListView.razor.scss
src/BootstrapBlazor.Server/Components/Samples/ListViews.razor
src/BootstrapBlazor/wwwroot/scss/theme/bootstrapblazor.scss
src/BootstrapBlazor.Server/Components/Samples/ListViews.razor.css
src/BootstrapBlazor/Components/ListView/ListView.razor.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#5423 Revert the grid layout in the ListView component.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider reverting the renaming of gap to margin in the scss file to keep the naming consistent with the grid layout.
  • The demo images now have a margin below them, which might not be desirable - consider removing it.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang enabled auto-merge (squash) February 22, 2025 10:35
@codecov
Copy link

codecov bot commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.87%. Comparing base (f3463e5) to head (c43f2b8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5424      +/-   ##
==========================================
- Coverage   99.87%   99.87%   -0.01%     
==========================================
  Files         646      646              
  Lines       29406    29387      -19     
  Branches     4133     4135       +2     
==========================================
- Hits        29368    29349      -19     
  Misses         38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 0c035d2 into main Feb 22, 2025
4 checks passed
@ArgoZhang ArgoZhang deleted the revert-listview branch February 22, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

revert(ListView): revert grid layout

2 participants