-
-
Notifications
You must be signed in to change notification settings - Fork 363
revert(ListView): revert grid layout #5424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryReverted the ListView component from a grid layout back to a flex layout to address issue #5423. Updated class diagram for ListView componentclassDiagram
class ListView {
-RenderFragment RenderItem
-RenderFragment RenderGroupItem
}
ListView ..> RenderFragment : uses
note for ListView "RenderGroup removed, RenderItem and RenderGroupItem updated to reflect flex layout"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider reverting the renaming of
gaptomarginin the scss file to keep the naming consistent with the grid layout. - The demo images now have a margin below them, which might not be desirable - consider removing it.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5424 +/- ##
==========================================
- Coverage 99.87% 99.87% -0.01%
==========================================
Files 646 646
Lines 29406 29387 -19
Branches 4133 4135 +2
==========================================
- Hits 29368 29349 -19
Misses 38 38 ☔ View full report in Codecov by Sentry. |
revert grid layout
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5423
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Reverts the grid layout of the ListView component and adjusts the styling to improve the visual presentation.
Bug Fixes:
Enhancements: