Skip to content

feat(Utility): improve registerBootstrapBlazorModule method #5936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2025
Merged

feat(Utility): improve registerBootstrapBlazorModule method #5936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a32b88e
chore: bump version 9.6.1-beta01
ArgoZhang May 2, 2025
f56a3d2
refactor: 优化 registerBootstrapBlazorModule 方法
ArgoZhang May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/BootstrapBlazor/BootstrapBlazor.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk.Razor">

<PropertyGroup>
<Version>9.6.0</Version>
<Version>9.6.1-beta01</Version>
</PropertyGroup>

<ItemGroup>
Expand Down
10 changes: 7 additions & 3 deletions src/BootstrapBlazor/wwwroot/modules/utility.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,17 +822,21 @@ export function registerBootstrapBlazorModule(name, identifier, callback) {
}
if (this._init === false) {
this._init = true;
cb(this);
if (isFunction(cb)) {
cb(this);
}
Comment on lines +825 to +827
Copy link

Copilot AI May 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider extracting the callback validation and invocation logic into a helper function to reduce duplication between the register and dispose methods.

Suggested change
if (isFunction(cb)) {
cb(this);
}
validateAndInvokeCallback(cb, this);

Copilot uses AI. Check for mistakes.
}
return this;
},
dispose: function (id, cb) {
if (id) {
this._items = this._items.filter(item => item !== id);
}
if (this._items.length === 0 && cb) {
if (this._items.length === 0) {
this._init = false;
cb(this);
if (isFunction(cb)) {
cb(this);
}
}
}
};
Expand Down