fix(Drawer): missing position variable #6906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR ensures the CSS custom property for the Drawer’s position is only emitted when a valid Position value is provided, preventing empty or invalid style declarations. Class diagram for updated Drawer component style logicclassDiagram
class Drawer {
-string? StyleString
}
Drawer : StyleString uses CssBuilder
class CssBuilder {
+AddClass(string className, bool condition)
+AddStyleFromAttributes(object attributes)
+Build()
}
Drawer --> CssBuilder : builds StyleString using
Flow diagram for Drawer style string construction with position variableflowchart TD
A["Drawer component initialized"] --> B["Check if Position is not null or empty"]
B -- true --> C["Add --bb-drawer-position CSS variable"]
B -- false --> D["Do not add position CSS variable"]
C --> E["Continue building style string"]
D --> E
E --> F["StyleString ready for rendering"]
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Pull Request Overview
Fixes a bug in the Drawer component where the position CSS variable was being added unconditionally, potentially causing issues when the Position property is null or empty. The fix adds a null/empty check before applying the CSS class.
- Adds conditional check to prevent adding position CSS variable when Position is null or empty
- Updates version number from beta to release version
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/BootstrapBlazor/Components/Drawer/Drawer.razor.cs | Adds null/empty check for Position property before adding CSS class |
| src/BootstrapBlazor/BootstrapBlazor.csproj | Updates version from beta to release |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| private string? StyleString => CssBuilder.Default() | ||
| .AddClass($"--bb-drawer-position: {Position};") | ||
| .AddClass($"--bb-drawer-position: {Position};", !string.IsNullOrEmpty(Position)) |
There was a problem hiding this comment.
The AddClass method is being used to add CSS custom properties (CSS variables), but it should be AddStyle instead. CSS custom properties belong in the style attribute, not the class attribute.
Copilot uses AI. Check for mistakes.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6906 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 739 739
Lines 31773 31773
Branches 4467 4467
=========================================
Hits 31773 31773
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6901
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes:
--bb-drawer-positionCSS variable when a valid Position value is provided.