Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Oct 15, 2025

Link issues

fixes #6911

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Prevent exceptions when clearing selected items in AutoFill samples by adding null checks around model-dependent rendering

Bug Fixes:

  • Fix NullReferenceException in AutoFill sample when the selected item is cleared

Enhancements:

  • Wrap image and EditorForm rendering in Model1, Model2, and Model3 demos with null checks

@Copilot Copilot AI review requested due to automatic review settings October 15, 2025 06:35
@bb-auto bb-auto bot added the documentation Improvements or additions to documentation label Oct 15, 2025
@bb-auto bb-auto bot added this to the 9.11.0 milestone Oct 15, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 15, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Added null-check guards in AutoFills sample component to prevent exceptions when clearing selected items, ensuring demo sections render only when models are non-null.

File-Level Changes

Change Details Files
Add null guards around sample renderings to avoid null reference exceptions
  • Wrapped image and EditorForm for Model1 with if (Model1 != null) check
  • Wrapped EditorForm for Model2 with if (Model2 != null) check
  • Wrapped EditorForm for Model3 with if (Model3 != null) check
src/BootstrapBlazor.Server/Components/Samples/AutoFills.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#6911 Add sample code for the AutoFill component demonstrating throwing an exception when clearing the selected item. The PR modifies the sample code to conditionally render EditorForm and image elements only when the model is not null, but does not add any code or documentation demonstrating how to throw an exception when clearing the selected item in the AutoFill component.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds null checks around EditorForm components in AutoFill samples to prevent exceptions when no item is selected.

  • Wraps EditorForm components with null checks to handle unselected AutoFill states
  • Prevents potential null reference exceptions when Model1, Model2, and Model3 are null
  • Improves robustness of the AutoFill demo components

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ArgoZhang ArgoZhang merged commit ed838ba into main Oct 15, 2025
5 of 6 checks passed
@ArgoZhang ArgoZhang deleted the doc-fill branch October 15, 2025 06:35
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (453e98d) to head (97e3dc4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6912   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          739       739           
  Lines        31773     31773           
  Branches      4467      4467           
=========================================
  Hits         31773     31773           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc(AutoFill): throw exception when clear selected item

1 participant