Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Oct 16, 2025

Link issues

fixes #6921

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

  • Reset _lastSelectedValueString to an empty string when SelectedItems is empty in OnParametersSet.

@Copilot Copilot AI review requested due to automatic review settings October 16, 2025 06:30
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 16, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This change ensures the MultiSelect component clears its internal lastSelectedValueString when no items remain selected, preventing stale values from persisting when Items becomes null or empty.

Class diagram for updated MultiSelect component logic

classDiagram
    class MultiSelect {
        - _currentValue : string
        - SelectedItems : List<Item>
        - Rows : List<Item>
        - _lastSelectedValueString : string
        + OnParametersSet()
    }
    MultiSelect : OnParametersSet()
    MultiSelect : _lastSelectedValueString is cleared when SelectedItems.Count == 0
Loading

File-Level Changes

Change Details Files
Reset internal lastSelectedValueString when no selections exist
  • Added a conditional block checking if SelectedItems.Count == 0
  • Assigned an empty string to _lastSelectedValueString within that block
src/BootstrapBlazor/Components/Select/MultiSelect.razor.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#6921 Support null Items parameter in MultiSelect component.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the enhancement New feature or request label Oct 16, 2025
@bb-auto bb-auto bot added this to the 9.11.0 milestone Oct 16, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the MultiSelect component where the last selected value was not being properly cleared when no items are available or selected. The fix ensures that when no items are selected, the internal _lastSelectedValueString field is reset to an empty string to maintain consistent state.

Key Changes

  • Added a null check and reset logic for _lastSelectedValueString when SelectedItems is empty

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Add a null check for Rows before iterating to prevent NullReferenceExceptions when the items collection is null.
  • Instead of unconditionally clearing _lastSelectedValueString when no items are selected, consider preserving its previous value to avoid losing user input if the list is temporarily empty.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Add a null check for Rows before iterating to prevent NullReferenceExceptions when the items collection is null.
- Instead of unconditionally clearing _lastSelectedValueString when no items are selected, consider preserving its previous value to avoid losing user input if the list is temporarily empty.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang merged commit a9bbd46 into main Oct 16, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the fix-multi branch October 16, 2025 06:31
@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (b187f2b) to head (89a28e9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6924   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          740       740           
  Lines        31811     31815    +4     
  Branches      4468      4469    +1     
=========================================
+ Hits         31811     31815    +4     
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang linked an issue Oct 19, 2025 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(MultiSelect): support null Items parameter problem opening the modal the 2nd time

1 participant