doc(Web): add video links #6935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideThe PR refactors various heading elements into styled paragraphs and enriches the documentation by injecting video tutorial resource sections on the Introduction and Tables sample pages. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- The new “视频资料” heading and related text are hard-coded in Chinese—consider using Localizer so these sections are translatable.
- Replacing semantic headings (h3/h4) with
may break the document outline and accessibility—consider keeping proper heading elements.
- The Bilibili video link lists appear in multiple places; extracting them into a shared component or partial could reduce duplication and simplify future updates.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new “视频资料” heading and related text are hard-coded in Chinese—consider using Localizer so these sections are translatable.
- Replacing semantic headings (h3/h4) with <p class="code-label"> may break the document outline and accessibility—consider keeping proper heading elements.
- The Bilibili video link lists appear in multiple places; extracting them into a shared component or partial could reduce duplication and simplify future updates.
## Individual Comments
### Comment 1
<location> `src/BootstrapBlazor.Server/Components/Pages/Introduction.razor:70` </location>
<code_context>
<li>@Localizer["AdvantageLi5"]</li>
</ul>
+<p class="code-label">视频资料</p>
+
+<ul class="ul-demo">
</code_context>
<issue_to_address>
**suggestion:** Consider localizing the new '视频资料' label for consistency.
Please use the Localizer for this label to maintain consistency and support internationalization.
Suggested implementation:
```
<p class="code-label">@Localizer["VideoResources"]</p>
```
You will need to add the "VideoResources" key and its appropriate translations to your resource files (e.g., .resx or JSON localization files) to ensure the label is properly localized.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Pull Request Overview
Adds external video resources and adjusts heading markup on documentation pages.
- Introduces a Tips section with video links on the Table samples page
- Replaces several h3/h4 headings with p.code-label in Introduction and adds a “视频资料” section with video links
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| src/BootstrapBlazor.Server/Components/Samples/Table/Tables.razor | Adds a Tips callout with Chinese copy and external Bilibili links for Table-related videos |
| src/BootstrapBlazor.Server/Components/Pages/Introduction.razor | Replaces heading tags with p.code-label, and adds a new “视频资料” block with external Bilibili links |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6935 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 740 740
Lines 31815 31815
Branches 4469 4469
=========================================
Hits 31815 31815
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6934
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add video tutorial resources to documentation and unify section label styling in the Introduction and Tables sample pages
New Features:
Bug Fixes:
Enhancements: