NATS transport infinity reconnect race condition

[truecooler]

Hi everyone, i have encountered race condition transport reconnect issue with stable reproduction.

Problem details
Looks like NATS transport occasionally looses the network connection.

Investigation showed that there is race condition between consumer restart process and native nats client callback.

1. TransportCheckProcessor occasionally checks transport for healthy:
   
   

   CAP/src/DotNetCore.CAP/Processor/IProcessor.TransportCheck.cs

   Line 36 in 3f91243

   _register.ReStart();

2. IConsumerRegister.Default.ReStart calls method Pulse that cancels task cancellation token _cts , sets _isHealthy to true, and calls Execute in order to run consumer:
   
   

   CAP/src/DotNetCore.CAP/Internal/IConsumerRegister.Default.cs

   Line 72 in 3f91243

   if (!IsHealthy() || force)

3. Meanwhile already running consumer thread receives _cts cancellation, then calls dispose that causes native nats client to be closed and disposed.
   
   

   CAP/src/DotNetCore.CAP/Internal/IConsumerRegister.Default.cs

   Line 150 in f0fad42

   client.Listening(_pollingDelay, _cts.Token);

4. When native nats client closes, it triggers ConnectedEventHandler(looks like typo, Disconnected is implied) event, that calls OnLogCallback that reassigns _isHealthy value to false
   
   
   

   CAP/src/DotNetCore.CAP.NATS/NATSConsumerClient.cs

   Line 180 in 99c2a8e

   OnLogCallback!(logArgs);

   
   

   CAP/src/DotNetCore.CAP/Internal/IConsumerRegister.Default.cs

   Line 312 in 3f91243

   _isHealthy = false;

As a result of race, _isHealthy seems to be false almost the time, that causes infinity reconnect loop

Reproduction
See my repo for reproduction: Just set your nats server and run Worker2
https://github.com/truecooler/CAPTest/tree/master/Worker2

Excepted: consumer connects without problem, no network issues

Actual: consumer looses the connection and occasianally prints:
"NATS server connection error."

[In-Wake]

I have some problem

[yang-xiaodong]

Fixed in 7.1.2-preview-198398083

[yang-xiaodong]

Hello @truecooler ,

I see in NuGet that these packages you created incorrectly use the prefix DotNetCore.CAP as well as the author of the Created By display, would you be willing to remove/modify them in NuGet?

For correct package names you can use prefixes like TrueCooler.CAP.XXX