FIX: doveadm-settings: Remove obsolete -U option from dsync_remote_cmd #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR intends to fix an error due to the default doveadm settings adding the obsolete and removed "-U" parameter to dsync. The option "-U" was removed in commit 4c04e4c (July 7, 2023) - "global: Remove replicator" removed. The "-U" parameter in the doveadm_settings struct was probably overlooked and causes errors like this: ``` doveadm sync -1 -u name@domain.tld remote:sub.remote.tld dsync-server: invalid option -- 'U' Error: doveadm: Unexpected or incomplete option: -U dsync-local(name@domain.tld)<I2I5HXkkC2mXLgwAXmhsDw>: Error: read(sub.remote.tld) failed: EOF (version not received) dsync-local(name@domain.tld)<I2I5HXkkC2mXLgwAXmhsDw>: Error: cmd sync: Remote command returned error 64: ssh sub.remote.tld doveadm dsync-server -uname@domain.tld -U ``` See also: https://dovecot.org/mailman3/archives/list/dovecot@dovecot.org/message/B3TQFAHCYVVXXEL4Y7KOPKJRWZ5I6X7D/
edmundlod
force-pushed
the
FIX-obsolete-U-option
branch
from
b692fc3 to
e9972a6
Compare
Contributor
|
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to fix an error due to the default doveadm settings adding the obsolete and removed "-U" parameter to
dsync_remote_cmd.The option "-U" was removed in commit 4c04e4c (July 7, 2023) - "global: Remove replicator" removed.
The "-U" parameter in a doveadm_settings struct was probably overlooked and causes errors like this:
See also: https://dovecot.org/mailman3/archives/list/dovecot@dovecot.org/message/B3TQFAHCYVVXXEL4Y7KOPKJRWZ5I6X7D/