Skip to content

fix(hooks): remove highlight when hovering disabled item#1408

Merged
silviuaavram merged 1 commit intomasterfrom
fix/1385/hover-after-disabled
Sep 16, 2022
Merged

fix(hooks): remove highlight when hovering disabled item#1408
silviuaavram merged 1 commit intomasterfrom
fix/1385/hover-after-disabled

Conversation

@silviuaavram
Copy link
Collaborator

@silviuaavram silviuaavram commented Sep 14, 2022

What:

Fixes #1385.

Why:

How:

Checklist:

  • Documentation
  • Tests
  • TypeScript Types
  • Flow Types
  • Ready to be merged

@silviuaavram silviuaavram force-pushed the fix/1385/hover-after-disabled branch from 88b03dc to 667ff12 Compare September 16, 2022 18:51
@codecov-commenter
Copy link

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (667ff12) compared to base (3eb7b44).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1408   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         1692      1693    +1     
  Branches       489       490    +1     
=========================================
+ Hits          1692      1693    +1     
Impacted Files Coverage Δ
src/hooks/useCombobox/testUtils.js 100.00% <ø> (ø)
src/hooks/useSelect/testUtils.js 100.00% <ø> (ø)
src/hooks/reducer.js 100.00% <100.00%> (ø)
src/hooks/useCombobox/index.js 100.00% <100.00%> (ø)
src/hooks/useSelect/index.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@silviuaavram silviuaavram changed the title wip fix(hooks): remove highlight when hovering disabled item Sep 16, 2022
@silviuaavram silviuaavram merged commit c188cc1 into master Sep 16, 2022
@silviuaavram silviuaavram deleted the fix/1385/hover-after-disabled branch September 16, 2022 19:02
@github-actions
Copy link

🎉 This PR is included in version 6.1.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Item highlighted when hovering another disabled item

2 participants