fix(disabled): remove disabled from spread regression#1689
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts useSelect and useCombobox prop getters so that disabled is no longer included in the returned props object by default (when not explicitly provided), addressing a regression where disabled: undefined could be spread onto consumer elements.
Changes:
- Update
getToggleButtonProps/getInputPropsimplementations to avoid explicitly returningdisabled, and gate handler attachment using the provideddisabledoption (rest.disabled). - Tighten TypeScript annotations for
useSelect/useComboboxprop getter parameters (using the corresponding*Optionstypes andGetPropsCommonOptions). - Add regression tests asserting the default prop getter outputs no longer include
disabledby default.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/hooks/useSelect/index.ts | Stops explicitly returning disabled in getToggleButtonProps and uses rest.disabled to decide whether to attach handlers. |
| src/hooks/useSelect/tests/getToggleButtonProps.test.js | Adds a regression test for default toggle button props shape. |
| src/hooks/useCombobox/index.types.ts | Updates getInputProps return value typing to no longer always include disabled by default. |
| src/hooks/useCombobox/index.ts | Stops explicitly returning disabled in getToggleButtonProps/getInputProps and uses rest.disabled to decide whether to attach handlers. |
| src/hooks/useCombobox/tests/getToggleButtonProps.test.js | Adds a regression test for default toggle button props shape. |
| src/hooks/useCombobox/tests/getInputProps.test.js | Adds a regression test for default input props shape. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎉 This PR is included in version 9.3.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
What
Part of the fix for #1688.
Remove the
disabledvalue from the getter props which was introduced in the ts migration changes PR.Why
Causes a regression when spreading.
How
Only use the
disabledvalue and not return it, unless the user adds it as props to the function.Changes
Remove from spread, only use
rest.disabledto perform the checks.Checklist