Skip to content

Commit 3ee0419

Browse files
committed
DefaultRecordsBuilder.size_in_bytes classmethod
1 parent 17ba216 commit 3ee0419

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

kafka/record/default_records.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -679,14 +679,15 @@ def size(self):
679679
"""
680680
return len(self._buffer)
681681

682-
def size_in_bytes(self, offset, timestamp, key, value, headers):
683-
if self._first_timestamp is not None:
684-
timestamp_delta = timestamp - self._first_timestamp
685-
else:
686-
timestamp_delta = 0
682+
@classmethod
683+
def header_size_in_bytes(self):
684+
return self.HEADER_STRUCT.size
685+
686+
@classmethod
687+
def size_in_bytes(self, offset_delta, timestamp_delta, key, value, headers):
687688
size_of_body = (
688689
1 + # Attrs
689-
size_of_varint(offset) +
690+
size_of_varint(offset_delta) +
690691
size_of_varint(timestamp_delta) +
691692
self.size_of(key, value, headers)
692693
)

test/record/test_default_records.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,8 @@ def test_written_bytes_equals_size_in_bytes_v2():
5757
producer_id=-1, producer_epoch=-1, base_sequence=-1,
5858
batch_size=999999)
5959

60-
size_in_bytes = builder.size_in_bytes(
61-
0, timestamp=9999999, key=key, value=value, headers=headers)
60+
size_in_bytes = DefaultRecordBatchBuilder.size_in_bytes(
61+
offset_delta=0, timestamp_delta=0, key=key, value=value, headers=headers)
6262

6363
pos = builder.size()
6464
meta = builder.append(

0 commit comments

Comments
 (0)