Skip to content

Commit 46319a3

Browse files
committed
cli fixups: producer py2 compat; consumer no stacktrace on KafkaError
1 parent 8d75d9a commit 46319a3

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

kafka/cli/consumer/__init__.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import logging
55

66
from kafka import KafkaConsumer
7+
from kafka.errors import KafkaError
78

89

910
def main_parser():
@@ -78,7 +79,10 @@ def run_cli(args=None):
7879
except KeyboardInterrupt:
7980
logger.info('Bye!')
8081
return 0
81-
except Exception:
82+
except KafkaError as e:
83+
logger.error(e)
84+
return 1
85+
except Exception as e:
8286
logger.exception('Error!')
8387
return 1
8488
finally:

kafka/cli/producer/__init__.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,14 @@ def log_result(res_or_err):
6666
else:
6767
logger.info("Message produced: %s", res_or_err)
6868

69+
try:
70+
input_py23 = raw_input
71+
except NameError:
72+
input_py23 = input
73+
6974
try:
7075
while True:
71-
value = input()
76+
value = input_py23()
7277
producer.send(config.topic, value=value.encode(config.encoding)).add_both(log_result)
7378
except KeyboardInterrupt:
7479
logger.info('Bye!')

0 commit comments

Comments
 (0)