Fail-fast on timeout constraint violations during KafkaConsumer creation #986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
saw that there are failures in travis. I'm taking a look at it. If you could provide instructions on how to run it locally with tox, that would be great. |
Contributor
Author
|
fixed - Another build has started. Monitoring. |
Contributor
|
Can we drop support for python 2.6? I'd rather be able to use |
Collaborator
|
I like the idea of such errors. |
dpkp
reviewed
Feb 24, 2017
kafka/consumer/group.py
Outdated
| fetch_max_wait_ms = self.config['fetch_max_wait_ms'] | ||
| if request_timeout_ms <= session_timeout_ms: | ||
| raise KafkaConfigurationError( | ||
| "Request timeout (" + str(request_timeout_ms) + ") must be larger than session timeout (" + |
Owner
There was a problem hiding this comment.
"Request timeout (%s) must be larger than session timeout (%s)" % (request_timeout_ms, session_timeout_ms) is another alternative here
Contributor
Author
There was a problem hiding this comment.
true, and better of course. fixing.
Contributor
Author
|
fixed string interpolation according to comment. Travis running. |
Owner
|
Thanks! |
88manpreet
pushed a commit
to Yelp/kafka-python
that referenced
this pull request
Apr 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #739