Skip to content

Conversation

@smt923
Copy link
Contributor

@smt923 smt923 commented May 3, 2018

This PR will enable (there doesn't appear to be an editor setting for it, just a color) the new active indent guide color

While I was there I brought the whitespace & now 'inactive' indent guide colors just a little bluer towards the dracula theme, as they didn't have a color before - if this isn't liked/desired I can make a new PR for just the active indent color, but it's not a drastic change and I think it fits in with the theme a little better than how it was before, where it was a little too grey-ish

Before w/ whitespace before and whitespace

After w/ whitespace after and whitespace

Before w/o whitespace before

After w/o whitespace after

Will close #73

(edited images after new commit)

Copy link
Member

@dsifford dsifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

Have a look at my comments and let me know what you think.

src/dracula.yml Outdated
other:
- &COMMENT '#6272A4'
- &LineHighlight '#44475A75'
- &Whitespace '#44475AC8'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we try #424450 for whitespace and see what that looks like?

Reason being: I'd like to keep as closely uniform as I can to dracula/vim.

Also, the C8 part to my knowledge shouldn't do anything here. The extended 2 digits of the hex values accounts for alpha and that needs to be 00-99 inclusive.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can we call this NonText rather than Whitespace to stay uniform with the vim terminology?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Makes sense to stick to the vim theme, and it looks good to me, pushing shortly

@smt923
Copy link
Contributor Author

smt923 commented May 3, 2018

Pushed the changes and updated the after images too

@dsifford
Copy link
Member

dsifford commented May 3, 2018

LGTM. Thanks!

@dsifford dsifford merged commit 43868f6 into dracula:master May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Add support for highlighted indent guides

2 participants