-
Notifications
You must be signed in to change notification settings - Fork 102
chore(deps): bump docker/setup-buildx-action from 2 to 3 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
LaszloGombos
merged 1 commit into
main
from
dependabot/github_actions/docker/setup-buildx-action-3
Mar 30, 2024
Merged
chore(deps): bump docker/setup-buildx-action from 2 to 3 #1
LaszloGombos
merged 1 commit into
main
from
dependabot/github_actions/docker/setup-buildx-action-3
Mar 30, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdeb3ac
to
acc0632
Compare
Conan-Kudo
pushed a commit
that referenced
this pull request
Mar 30, 2024
The MacBook Pro 2017 (MacBookPro14,1) connects the keyboard via SPI: ``` $ dmesg input: Apple SPI Keyboard as /devices/pci0000:00/0000:00:1e.3/pxa2xx-spi.3/spi_master/spi2/spi-APP000D:00/input/input4 ``` The SPI controller requires the `intel_lpss_pci` kernel module: ``` $ lspci -vv 00:1e.3 Signal processing controller: Intel Corporation Sunrise Point-LP Serial IO SPI Controller #1 (rev 21) Subsystem: Intel Corporation Sunrise Point-LP Serial IO SPI Controller Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 0, Cache Line Size: 256 bytes Interrupt: pin D routed to IRQ 23 Region 0: Memory at 9282c000 (64-bit, non-prefetchable) [size=4K] Capabilities: [80] Power Management version 3 Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-) Status: D3 NoSoftRst+ PME-Enable- DSel=0 DScale=0 PME- Capabilities: [90] Vendor Specific Information: Len=14 <?> Kernel driver in use: intel-lpss Kernel modules: intel_lpss_pci ``` Fedora builds `intel_lpss_pci` into the kernel: ``` $ grep INTEL_LPSS_PCI /lib/modules/6.5.11-300.fc39.x86_64/config CONFIG_MFD_INTEL_LPSS_PCI=y ``` But Ubuntu builds `intel_lpss_pci` only as module: ``` $ grep INTEL_LPSS_PCI /boot/config-6.5.0-10-generic CONFIG_MFD_INTEL_LPSS_PCI=m ``` So explicitly include `intel_lpss_pci` to support the keyboard. Bug-Ubuntu: https://launchpad.net/bugs/2042710 fixes: df381b7 ("feat(kernel-modules): driver support for macbook keyboards") Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 2 to 3. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@v2...v3) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
acc0632
to
f740317
Compare
LaszloGombos
approved these changes
Mar 30, 2024
aafeijoo-suse
referenced
this pull request
in openSUSE/dracut-ng
May 31, 2024
The MacBook Pro 2017 (MacBookPro14,1) connects the keyboard via SPI: ``` $ dmesg input: Apple SPI Keyboard as /devices/pci0000:00/0000:00:1e.3/pxa2xx-spi.3/spi_master/spi2/spi-APP000D:00/input/input4 ``` The SPI controller requires the `intel_lpss_pci` kernel module: ``` $ lspci -vv 00:1e.3 Signal processing controller: Intel Corporation Sunrise Point-LP Serial IO SPI Controller #1 (rev 21) Subsystem: Intel Corporation Sunrise Point-LP Serial IO SPI Controller Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Latency: 0, Cache Line Size: 256 bytes Interrupt: pin D routed to IRQ 23 Region 0: Memory at 9282c000 (64-bit, non-prefetchable) [size=4K] Capabilities: [80] Power Management version 3 Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-) Status: D3 NoSoftRst+ PME-Enable- DSel=0 DScale=0 PME- Capabilities: [90] Vendor Specific Information: Len=14 <?> Kernel driver in use: intel-lpss Kernel modules: intel_lpss_pci ``` Fedora builds `intel_lpss_pci` into the kernel: ``` $ grep INTEL_LPSS_PCI /lib/modules/6.5.11-300.fc39.x86_64/config CONFIG_MFD_INTEL_LPSS_PCI=y ``` But Ubuntu builds `intel_lpss_pci` only as module: ``` $ grep INTEL_LPSS_PCI /boot/config-6.5.0-10-generic CONFIG_MFD_INTEL_LPSS_PCI=m ``` So explicitly include `intel_lpss_pci` to support the keyboard. Bug-Ubuntu: https://launchpad.net/bugs/2042710 fixes: df381b7 ("feat(kernel-modules): driver support for macbook keyboards") Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com> (cherry picked from commit 19a0ba9)
LaszloGombos
pushed a commit
that referenced
this pull request
Aug 9, 2025
Sudhakar Verma from the Ubuntu security team found a memory corruption: ``` $ pwd /tmp/dracut-ng/src/util $ CC=clang-17 CXX=clang++-17 CFLAGS="-fsanitize=address" cmake . -- The C compiler identification is Clang 17.0.6 -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working C compiler: /usr/bin/clang-17 - skipped -- Detecting C compile features -- Detecting C compile features - done -- Configuring done (0.3s) -- Generating done (0.0s) -- Build files have been written to: /tmp/dracut-ng/src/util $ CC=clang-17 CXX=clang++-17 CFLAGS="-fsanitize=address" make [ 50%] Building C object CMakeFiles/dracut-util.dir/util.c.o [100%] Linking C executable dracut-util [100%] Built target dracut-util $ ln -s $PWD/dracut-util dracut-getargs $ ln -s $PWD/dracut-util dracut-getarg $ CMDLINE=' "' ./dracut-getarg ' ' AddressSanitizer:DEADLYSIGNAL ================================================================= ==163118==ERROR: AddressSanitizer: SEGV on unknown address 0x50210000001d (pc 0x599a6b7d4c07 bp 0x7ffe44ea9ef0 sp 0x7ffe44ea9da0 T0) ==163118==The signal is caused by a READ memory access. #0 0x599a6b7d4c07 in next_arg util.c #1 0x599a6b7d3e75 in getarg util.c #2 0x599a6b7d3448 in main (/tmp/dracut-ng/src/util/dracut-util+0x108448) (BuildId: ea28a61b3c6dd0a75c505cd1749f8711779bd819) #3 0x72381be2a1c9 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16 #4 0x72381be2a28a in __libc_start_main csu/../csu/libc-start.c:360:3 #5 0x599a6b6f7304 in _start (/tmp/dracut-ng/src/util/dracut-util+0x2c304) (BuildId: ea28a61b3c6dd0a75c505cd1749f8711779bd819) AddressSanitizer can not provide additional info. SUMMARY: AddressSanitizer: SEGV util.c in next_arg ==163118==ABORTING ``` The variable `i` in `next_arg` is an unsigned integeter. `i - 1` will result in an underflow in case `i` is 0.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps docker/setup-buildx-action from 2 to 3.
Release notes
Sourced from docker/setup-buildx-action's releases.
... (truncated)
Commits
2b51285
Merge pull request #306 from docker/dependabot/npm_and_yarn/docker/actions-to...0f00370
chore: update generated content11c9683
build(deps): bump@docker/actions-toolkit
from 0.18.0 to 0.19.056a16b8
Merge pull request #303 from crazy-max/fix-inputsc23f46e
chore: update generated contentf876da6
rename and align config inputsb7cf918
Merge pull request #304 from crazy-max/rm-docs-dir0150f0e
chore: remove docs dird89f1f9
Merge pull request #302 from docker/dependabot/npm_and_yarn/docker/actions-to...12d65f6
chore: update generated contentDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)