feat: add a few function to utils for count #21

freedomlang · 2018-10-13T10:23:20Z

Resolve #23

juliankrispel · 2018-10-16T14:47:21Z

import { getWordCount } from '@djsp/utils'
import { EditorContainer, Plugin, Editor } from '@djsp/core'

<EditorContainer>
  <Plugin>{({ editorState }) => getWordCount(editorState)}</Plugin>
  <Editor />
</EditorContainer>

juliankrispel

Looks great! I'll help with getting it merged 👍 - if you could address some of the concerns that'd be fabbb!

juliankrispel · 2018-10-30T15:16:00Z

examples/counter/src/index.js

+          onChange={this.onChange}>
+          <div>Char count: {getCharCount(this.state.editorState)}</div>
+          <div>Word count: {getWordCount(this.state.editorState)}</div>
+          <div>Line count: {getLineCount(this.state.editorState)}</div>


Make this a separate component WordCountPlugin.js

export default () => <Plugin>{({ editorState }) => <Fragment> <div>Char count: {getCharCount(this.state.editorState)}</div> <div>Word count: {getWordCount(this.state.editorState)}</div> <div>Line count: {getLineCount(this.state.editorState)}</div> </Fragment>

And import it to index.js

juliankrispel · 2018-10-30T15:16:51Z

packages/utils/dist/index.es.js

@@ -1,4 +1,5 @@
 import { AtomicBlockUtils, RichUtils, EditorState, Modifier } from 'draft-js';
+import punycode from 'punycode';


How big is this dependency? Also, it needs to be added to external in the rollup config

why do we need this exactly?

This dependency used for handle unicode characters.

It's size is 142B(MINIFIED). Still need to added it into external?

juliankrispel · 2018-10-30T15:19:19Z

packages/utils/dist/index.js

@@ -1,8 +1,11 @@
 'use strict';

 Object.defineProperty(exports, '__esModule', { value: true });


dist folder should be ignored (let's check the .gitignore file

juliankrispel · 2018-10-30T15:19:37Z

packages/utils/package.json

 {
  "name": "@djsp/utils",
-  "version": "0.0.3",
+  "version": "0.0.4",


this will update after a rebase

Ah, after git rebase master, the version updated to 0.1.5. Not sure if it is right

juliankrispel · 2018-10-30T15:19:55Z

packages/utils/src/index.js

  Modifier,
 } from 'draft-js'
 import type DraftEntityInstance from 'draft-js/lib/DraftEntityInstance'
+// eslint-disable-next-line


shouldn't need to use the eslint comment here

Eslint will throw error about deprecated-api. So i add eslint-disable-next-line node/no-deprecated-api in the next commit

juliankrispel · 2018-10-30T15:20:14Z

packages/utils/src/index.js

  return entity && entity.getType() === entityType
 }
+
+export function getCharCount(editorState: EditorState): number {


does this pass flow?

Currently, @djsp/utils can not pass flow. Looks like missing some files in flow-lib

freedomlang requested a review from juliankrispel October 13, 2018 10:23

freedomlang force-pushed the counter branch from df5f31e to c0f6831 Compare October 13, 2018 15:54

freedomlang force-pushed the counter branch from 6173bb6 to 20293f3 Compare October 22, 2018 14:19

freedomlang changed the title ~~feat: add counter plugin~~ feat: add a few function to utils for count Oct 28, 2018

juliankrispel suggested changes Oct 30, 2018

View reviewed changes

juliankrispel assigned freedomlang Oct 31, 2018

freedomlang force-pushed the counter branch 2 times, most recently from 41e401a to db9b69e Compare November 19, 2018 11:17

freedomlang and others added 8 commits November 28, 2018 14:37

feat: add counter plugin

68f10a3

docs: add example for counter

d894a87

fix lint error

61c357b

feat(utils): move charCount, lineCount and wordCound into utils

3c12ff5

docs: update example for counter

555952e

optimize counter-example and fix lint error

926ab28

update examples, move depdency

5be158f

lol

19ec241

juliankrispel force-pushed the counter branch from db9b69e to 19ec241 Compare November 28, 2018 22:55

juliankrispel merged commit fedec94 into master Nov 28, 2018

juliankrispel deleted the counter branch November 28, 2018 22:57

		@@ -1,4 +1,5 @@
		import { AtomicBlockUtils, RichUtils, EditorState, Modifier } from 'draft-js';
		import punycode from 'punycode';

		@@ -1,8 +1,11 @@
		'use strict';

		Object.defineProperty(exports, '__esModule', { value: true });

feat: add a few function to utils for count #21

feat: add a few function to utils for count #21

Uh oh!

Conversation

freedomlang commented Oct 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

juliankrispel commented Oct 16, 2018

Uh oh!

juliankrispel left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

freedomlang commented Oct 13, 2018 •

edited

Loading