Skip to content

improve play video silence mode - 51 #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2025
Merged

improve play video silence mode - 51 #1000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a1c201
update dependency in useEffect
sieu-db Feb 13, 2025
21c5d11
support silence for video component
sieu-db Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions example/src/VideoPlayerExample.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,17 @@ const VideoPlayerExample: React.FC = () => {
resizeMode="cover"
/>
</Section>
<Section style={{}} title="VideoPlayer (Silent mode)">
<VideoPlayer
style={{ width: 350, height: 250 }}
source={{
uri: "http://static.draftbit.com/videos/intro-to-draftbit.mp4",
}}
useNativeControls
resizeMode="cover"
playsInSilentModeIOS={true}
/>
</Section>
<Section style={{}} title="VideoPlayer (Poster and custom controls)">
<VideoPlayer
ref={videoPlayerRef}
Expand Down
18 changes: 15 additions & 3 deletions packages/core/src/components/MediaPlayer/VideoPlayer/VideoPlayer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from "react";
import { ImageResizeMode } from "react-native";
import { ImageResizeMode, Platform } from "react-native";
import {
Video as VideoPlayerComponent,
VideoProps as ExpoVideoProps,
Expand Down Expand Up @@ -35,6 +35,18 @@ export interface VideoPlayerRef extends MediaPlayerRef {
toggleFullscreen: () => void;
}

// Setting playsInSilentModeIOS prop directly on Video component is unreliable,
// so we need to set the audio mode globally before playing.
// See:
// https://github.com/expo/expo/issues/7485
// https://stackoverflow.com/questions/57371543/how-to-fix-video-play-but-dont-have-sound-on-ios-with-expo
const triggerAudio = async (ref: React.RefObject<MediaPlayerRef>) => {
if (ref && ref?.current && Platform.OS === "ios") {
await Audio.setAudioModeAsync({ playsInSilentModeIOS: true });
ref.current.play();
}
};

const VideoPlayer = React.forwardRef<VideoPlayerRef, VideoPlayerProps>(
(
{
Expand Down Expand Up @@ -116,8 +128,8 @@ const VideoPlayer = React.forwardRef<VideoPlayerRef, VideoPlayerProps>(
}, [playsInSilentModeIOS]);

React.useEffect(() => {
updateAudioMode();
}, [updateAudioMode]);
if (isPlaying) triggerAudio(mediaPlaybackWrapperRef);
}, [mediaPlaybackWrapperRef, isPlaying]);

React.useImperativeHandle(
ref,
Expand Down