Handle paths strictly #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattn
commented
Oct 18, 2021
draftcode
approved these changes
Oct 19, 2021
| Pair<Editor, PsiFile> p = | ||
| MoreWriteActions.computeAndWaitForDocument( | ||
| () -> { | ||
| ; |
| MoreWriteActions.computeAndWaitForDocument( | ||
| () -> { | ||
| ; | ||
| String path = null; |
Owner
There was a problem hiding this comment.
= null is not needed because the path is always initialized (or bail out by throwing an exception). Keep this uninitialized unless the default initialized value makes sense for all cases. Usage of uninitialized variables is easy to detect, vs initializing with a wrong value is not.
| this.diagnosticsProducer = diagnosticsProducer; | ||
| } | ||
|
|
||
| @Nullable |
Owner
There was a problem hiding this comment.
Now looking at the code, we don't use this method at all. Let's delete this getByPath
Contributor
Author
|
Sorry, I missed the notification about this. & Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YAY
