Skip to content

Fix C Code #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2025
+5 −5
Merged

Fix C Code #131

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2eb2b3f
Add fs_operations_t as a pointer
oito8bits Oct 21, 2025
c1b80e7
Fix function return
oito8bits Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions 08_VirtualFileSystem/02_VirtualFileSystem.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ typedef struct {
char device[VFS_PATH_LENGTH];
char mountpoint[VFS_PATH_LENGTH];

fs_operations_t operations;
fs_operations_t *operations;

} mountpoint_t;
```
Expand Down Expand Up @@ -314,7 +314,7 @@ int open(const char *path, int flags){

if (mountpoint != NULL) {
char *rel_path = get_rel_path(mountpoint, path);
int fs_specific_id = mountpoint->operations.open(rel_path, flags);
int fs_specific_id = mountpoint->operations->open(rel_path, flags);
if (fs_specific_id != ERROR) {
/* IMPLEMENTATION LEFT AS EXERCISE */
// Get a new vfs descriptor id vfs_id
Expand Down Expand Up @@ -344,13 +344,13 @@ int close(int fildes) {
mountpoint_id = vfs_opened_files[fildes].mountpoint_id;
mountpoint_t *mountpoint = get_mountpoint_by_id(mountpoint_id);
fs_file_id = vfs_opened_files[fildes].fs_file_id;
fs_close_result = mountpoint->operations.close(fs_file_id);
fs_close_result = mountpoint->operations->close(fs_file_id);
if(fs_close_result == 0) {
vfs_opened_files[fildes].fs_file_id = -1;
return 0;
}
return -1;
}
return -1;
}
```

Expand Down Expand Up @@ -399,7 +399,7 @@ ssize_t read(int fildes, void *buf, size_t nbytes) {
int mountpoint_id = vfs_opened_files[fildes].mountpoint_id;
mountpoint_t *mountpoint = get_mountpoint_by_id(mountpoint_id);
int fs_file_id = vfs_opened_files[fildes].fs_file_id;
int bytes_read = mountpoints->operations.read(fs_file_id, buf, nbytes);
int bytes_read = mountpoints->operations->read(fs_file_id, buf, nbytes);
if (opened_files[fildes].buf_read_pos + nbytes < opened_files[fildes].file_size) {
opened_files[fildes].buf_read_pos += nbytes;
} else {
Expand Down