Skip to content

[accordion] Add the accordion component #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Feb 28, 2019
Merged

[accordion] Add the accordion component #18

merged 12 commits into from
Feb 28, 2019

Conversation

GianlucaGuarini
Copy link
Contributor

I was able to get the 100% coverage on this component ;)

@coveralls
Copy link

coveralls commented Feb 22, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 252

  • 29 of 29 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.2%) to 83.047%
Totals Coverage Status
Change from base Build 236: 2.2%
Covered Lines: 238
Relevant Lines: 267
💛 - Coveralls

nirazul
nirazul reviewed Feb 23, 2019
View reviewed changes
Copy link
Contributor

@nirazul nirazul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks very good. Thanks for implementing it!
I've added a few comments and hints. Also, I'd like to go through the documentation a bit and tweak the language, but I can do this in another PR. It's only polishing.

@nirazul nirazul removed their assignment Feb 23, 2019
@faebeee
Copy link
Contributor

faebeee commented Feb 25, 2019

LGTM once again =)

@faebeee faebeee assigned GianlucaGuarini and unassigned faebeee Feb 25, 2019
@nirazul nirazul self-requested a review February 28, 2019 14:04
@GianlucaGuarini GianlucaGuarini merged commit 64cfa47 into develop Feb 28, 2019
@GianlucaGuarini GianlucaGuarini deleted the feature/accordion branch February 28, 2019 16:45
nirazul
nirazul reviewed Mar 2, 2019
View reviewed changes
Copy link
Contributor

@nirazul nirazul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@faebeee faebeee Awaiting requested review from faebeee

1 more reviewer

@nirazul nirazul nirazul left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@GianlucaGuarini GianlucaGuarini

Labels

ACK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GianlucaGuarini @coveralls @faebeee @nirazul