Skip to content

Feature/unit test simplification #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 5, 2018
Merged

Feature/unit test simplification #3

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7f841a6
Change modal name
Aug 24, 2018
689c677
Simplify overlay unit tests
Aug 24, 2018
7d36747
Minor improvement
Aug 24, 2018
36e7f19
Merge branch 'develop' of github.com:dreipol/vue-ui into feature/unit…
Sep 5, 2018
5497d26
Fix merge fail
Sep 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/modules/overlay/module.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,13 +112,13 @@ describe('Overlay spec', () => {
await actions.openOverlay({ commit, state }, { id: 'foo', props: { title: 'bar' } });

const [mountOverlayEventArgs, openOverlayEventArgs] = commit.args;
const [openOverlayEventMutationType, openOverlayEventOverlayData] = openOverlayEventArgs;
const [openOverlayEventMutationType, openOverlayEventData] = openOverlayEventArgs;

expect(mountOverlayEventArgs).to.be.deep.equal([MOUNT_OVERLAY, { id: 'foo' }]);
expect(openOverlayEventMutationType).to.be.equal(OPEN_OVERLAY);

expect(openOverlayEventOverlayData.props.title).to.to.not.be.undefined;
expect(openOverlayEventOverlayData.props.title).to.be.equal('bar', 'The payload was properly forwarded');
expect(openOverlayEventData.props.title).to.to.not.be.undefined;
expect(openOverlayEventData.props.title).to.be.equal('bar', 'The payload was properly forwarded');
});

it('Opening the same overlay twice will not dispatch the mounting mutation again', async function() {
Expand All @@ -131,12 +131,12 @@ describe('Overlay spec', () => {

await actions.openOverlay({ commit, state }, { id: 'foo', props: { title: 'baz' } });

const [openOverlayEventMutationType, openOverlayEventOverlayData] = commit.args[0];
const [openOverlayEventMutationType, openOverlayEventData] = commit.args[0];

expect(commit.args).to.have.length(1);
expect(openOverlayEventMutationType).to.be.equal(OPEN_OVERLAY);
expect(openOverlayEventOverlayData.props.title).to.to.not.be.undefined;
expect(openOverlayEventOverlayData.props.title).to.be.equal('baz', 'The payload was properly forwarded');
expect(openOverlayEventData.props.title).to.to.not.be.undefined;
expect(openOverlayEventData.props.title).to.be.equal('baz', 'The payload was properly forwarded');
});
});

Expand Down