-
Notifications
You must be signed in to change notification settings - Fork 0
Update overlay doc #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thaaanks!
src/components/overlay/README.md
Outdated
opacity: 1; | ||
} | ||
} | ||
// Mobile nav |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rename this to sth like Example overlay
?
src/components/overlay/README.md
Outdated
&.ui-accordion__is-animating { | ||
.ui-accordion--body { | ||
transition: opacity 300ms ease, max-height 300ms ease; | ||
.ui-overlay--revealer { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove this selector, it's not clear what it does in the example.
src/components/overlay/README.md
Outdated
@include ui-overlay--full-width; | ||
@include ui-overlay--restrict-scrolling-to-element; | ||
@include ui-overlay--restrict-pointerevents-to-element($allow-backdrop-click-area: false); | ||
@include ui-overlay--set-layer-hierarchy($layer: 'navigation-overlay'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rename this to example-overlay
No description provided.