Skip to content

Conversation

faebeee
Copy link
Contributor

@faebeee faebeee commented Sep 17, 2019

No description provided.

Copy link
Contributor

@nirazul nirazul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thaaanks!

opacity: 1;
}
}
// Mobile nav
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename this to sth like Example overlay?

&.ui-accordion__is-animating {
.ui-accordion--body {
transition: opacity 300ms ease, max-height 300ms ease;
.ui-overlay--revealer {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove this selector, it's not clear what it does in the example.

@include ui-overlay--full-width;
@include ui-overlay--restrict-scrolling-to-element;
@include ui-overlay--restrict-pointerevents-to-element($allow-backdrop-click-area: false);
@include ui-overlay--set-layer-hierarchy($layer: 'navigation-overlay');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rename this to example-overlay

@coveralls
Copy link

Pull Request Test Coverage Report for Build 346

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.018%

Totals Coverage Status
Change from base Build 340: 0.0%
Covered Lines: 261
Relevant Lines: 291

💛 - Coveralls

@nirazul nirazul assigned faebeee and unassigned nirazul and GianlucaGuarini Sep 18, 2019
@faebeee faebeee merged commit c9b6ca3 into master Sep 18, 2019
@faebeee faebeee deleted the feature/overlay-doc branch September 18, 2019 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants