Skip to content

[floating-selects] Add the floating label support to the select inputs #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 27, 2020
Merged

[floating-selects] Add the floating label support to the select inputs #34

merged 2 commits into from
Jan 27, 2020

Conversation

GianlucaGuarini
Copy link
Contributor

No description provided.

faebeee
faebeee suggested changes Jan 27, 2020
View reviewed changes
@coveralls
Copy link

Pull Request Test Coverage Report for Build 357

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.385%
Totals Coverage Status
Change from base Build 354: 0%
Covered Lines: 155
Relevant Lines: 179
💛 - Coveralls

@faebeee
Copy link
Contributor

faebeee commented Jan 27, 2020

LGTM

@GianlucaGuarini GianlucaGuarini merged commit 18e96e4 into develop Jan 27, 2020
@GianlucaGuarini GianlucaGuarini deleted the feature/floating-selects branch January 27, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@faebeee faebeee faebeee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@faebeee faebeee

Labels

ACK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GianlucaGuarini @coveralls @faebeee