Add EloquentMagicMethodToQueryBuilderRector rule #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterfox
added a commit
to peterfox/rector-laravel
that referenced
this pull request
Sep 18, 2023
commit c664be4 Author: Clément Birklé <clement.birkle@gmail.com> Date: Mon Sep 18 22:16:17 2023 +0200 Add EloquentMagicMethodToQueryBuilderRector rule (driftingly#132) * Add EloquentMagicMethodToQueryBuilderRector rule * Fix PHPStan errors commit 2af4076 Author: Andrew Miller <ikari7789@yahoo.com> Date: Tue Sep 19 05:14:23 2023 +0900 Remove MethodCallRename rule from Laravel80 ruleset (driftingly#134) It references the commit where the function was "renamed", but the next commit in the laravel/framework repository is re-adding the function. laravel/framework@8e0914e As `assertExactJson()` and `assertSimilarJson()` have very different expectations, I think this could change could inadvertently alter tests to be less accurate. Co-authored-by: Anthony Clark <anthonyclark@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.