feat: add ReplaceFakerPropertyFetchWithMethodCallRector

config/sets/packages/faker/faker-10.php

@@ -0,0 +1,11 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use RectorLaravel\Rector\PropertyFetch\ReplaceFakerPropertyFetchWithMethodCallRector;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->import(__DIR__ . '/../../../config.php');
+    $rectorConfig->rule(ReplaceFakerPropertyFetchWithMethodCallRector::class);
+};

docs/rector_rules_overview.md

@@ -1,4 +1,4 @@
-# 83 Rules Overview
+# 84 Rules Overview
 
 ## AbortIfRector
 
@@ -593,6 +593,7 @@ Use the event or dispatch helpers instead of the static dispatch method.
 -ExampleJob::dispatch($email);
 +dispatch(new ExampleJob($email));
 ```
+
 <br>
 
 ```diff
@@ -1259,6 +1260,19 @@ Replace `$this->faker` with the `fake()` helper function in Factories
 
 <br>
 
+## ReplaceFakerPropertyFetchWithMethodCallRector
+
+Replace deprecated faker property fetch with method call
+
+- class: [`RectorLaravel\Rector\PropertyFetch\ReplaceFakerPropertyFetchWithMethodCallRector`](../src/Rector/PropertyFetch/ReplaceFakerPropertyFetchWithMethodCallRector.php)
+
+```diff
+-$faker->name,
++$faker->name(),
+```
+
+<br>
+
 ## ReplaceServiceContainerCallArgRector
 
 Changes the string or class const used for a service container make call

src/Rector/PropertyFetch/ReplaceFakerPropertyFetchWithMethodCallRector.php

@@ -0,0 +1,61 @@
+<?php
+
+declare(strict_types=1);
+
+namespace RectorLaravel\Rector\PropertyFetch;
+
+use PhpParser\BuilderFactory;
+use PhpParser\Node;
+use PhpParser\Node\Expr\PropertyFetch;
+use PHPStan\Type\ObjectType;
+use RectorLaravel\AbstractRector;
+use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
+use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+
+/**
+ * @see \RectorLaravel\Tests\Rector\PropertyFetch\ReplaceFakerInstanceWithHelperRector\ReplaceFakerInstanceWithHelperRectorTest
+ */
+final class ReplaceFakerPropertyFetchWithMethodCallRector extends AbstractRector
+{
+    public function __construct(
+        private readonly BuilderFactory $builderFactory,
+    ) {}
+
+    public function getRuleDefinition(): RuleDefinition
+    {
+        return new RuleDefinition(
+            'Replace deprecated faker property fetch with method call',
+            [
+                new CodeSample(
+                    <<<'CODE_SAMPLE'
+$faker->name,
+CODE_SAMPLE
+                    ,
+                    <<<'CODE_SAMPLE'
+$faker->name(),
+CODE_SAMPLE
+                ),
+            ]
+        );
+    }
+
+    /**
+     * @return array<class-string<Node>>
+     */
+    public function getNodeTypes(): array
+    {
+        return [PropertyFetch::class];
+    }
+
+    /**
+     * @param  PropertyFetch  $node
+     */
+    public function refactor(Node $node): ?Node
+    {
+        if (! $this->isObjectType($node->var, new ObjectType('Faker\Generator'))) {
+            return null;
+        }
+
+        return $this->builderFactory->methodCall($node->var, $node->name);
+    }
+}

src/Set/LaravelSetProvider.php

@@ -6,6 +6,7 @@
 use Rector\Set\Contract\SetProviderInterface;
 use Rector\Set\ValueObject\ComposerTriggeredSet;
 use Rector\Set\ValueObject\Set;
+use RectorLaravel\Set\Packages\Faker\FakerSetList;
 use RectorLaravel\Set\Packages\Livewire\LivewireSetList;
 
 final class LaravelSetProvider implements SetProviderInterface
@@ -102,6 +103,12 @@ public function provide(): array
                 '3.0',
                 LivewireSetList::LIVEWIRE_30,
             ),
+            new ComposerTriggeredSet(
+                self::GROUP_NAME,
+                'fakerphp/faker',
+                '1.0',
+                FakerSetList::FAKER_10,
+            ),
             ...$this->getLaravelVersions(),
         ];
     }

src/Set/Packages/Faker/FakerSetList.php

@@ -0,0 +1,8 @@
+<?php
+
+namespace RectorLaravel\Set\Packages\Faker;
+
+final class FakerSetList
+{
+    final public const string FAKER_10 = __DIR__ . '/../../../../config/sets/packages/faker/faker-10.php';
+}

stubs/Faker/Generator.php

@@ -0,0 +1,9 @@
+<?php
+
+namespace Faker;
+
+if (class_exists('Faker\Generator')) {
+    return;
+}
+
+class Generator {}

tests/Rector/PropertyFetch/ReplaceFakerPropertyFetchWithMethodCallRector/Fixture/dynamic_property.php.inc

@@ -0,0 +1,33 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ReplaceFakerPropertyFetchWithMethodCallRector\Fixture;
+
+use Faker\Generator;
+
+function fake(): Generator
+{
+    return new Generator();
+}
+
+/** @var Generator $faker */
+$faker->name;
+fake()->name;
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ReplaceFakerPropertyFetchWithMethodCallRector\Fixture;
+
+use Faker\Generator;
+
+function fake(): Generator
+{
+    return new Generator();
+}
+
+/** @var Generator $faker */
+$faker->name();
+fake()->name();
+
+?>

tests/Rector/PropertyFetch/ReplaceFakerPropertyFetchWithMethodCallRector/Fixture/fixture.php.inc

@@ -0,0 +1,23 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ReplaceFakerPropertyFetchWithMethodCallRector\Fixture;
+
+use Faker\Generator;
+
+$property = 'name';
+/** @var Generator $faker */
+$faker->$property;
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ReplaceFakerPropertyFetchWithMethodCallRector\Fixture;
+
+use Faker\Generator;
+
+$property = 'name';
+/** @var Generator $faker */
+$faker->{$property}();
+
+?>

tests/Rector/PropertyFetch/ReplaceFakerPropertyFetchWithMethodCallRector/ReplaceFakerPropertyFetchWithMethodCallRectorTest.php

@@ -0,0 +1,31 @@
+<?php
+
+declare(strict_types=1);
+
+namespace RectorLaravel\Tests\Rector\PropertyFetch\ReplaceFakerPropertyFetchWithMethodCallRector;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class ReplaceFakerPropertyFetchWithMethodCallRectorTest extends AbstractRectorTestCase
+{
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    /**
+     * @test
+     */
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

tests/Rector/PropertyFetch/ReplaceFakerPropertyFetchWithMethodCallRector/config/configured_rule.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use RectorLaravel\Rector\PropertyFetch\ReplaceFakerPropertyFetchWithMethodCallRector;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->rule(ReplaceFakerPropertyFetchWithMethodCallRector::class);
+};