feat: add MakeModelAttributesAndScopesProtectedRector #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebdw
force-pushed
the
calebdw/push-kquotttqsuqn
branch
2 times, most recently
from
888675b to
51b7ddc
Compare
calebdw
force-pushed
the
calebdw/push-kquotttqsuqn
branch
from
51b7ddc to
1d2a2c1
Compare
GeniJaho
requested changes
Aug 17, 2025
src/Rector/ClassMethod/MakeModelAttributesAndScopesProtectedRector.php
Outdated
Show resolved
Hide resolved
calebdw
force-pushed
the
calebdw/push-kquotttqsuqn
branch
from
ab247db to
7cd51ac
Compare
This automatically converts all Model attributes and scopes to protected.
calebdw
force-pushed
the
calebdw/push-kquotttqsuqn
branch
from
7cd51ac to
4998920
Compare
Contributor
Author
|
Thanks! |
This was referenced Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This automatically converts all Model attributes and scopes to protected. It is actually an error for them to be
private(as they are called from the parent Model) and they should not bepublicas a user should never call them directlyThanks!