Skip to content

Commit cc1cc11

Browse files
committed
fix(run): fix livereload option for v2 run
1 parent d3a1673 commit cc1cc11

File tree

1 file changed

+14
-3
lines changed

1 file changed

+14
-3
lines changed

lib/ionic/cordova.js

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,10 @@ var Task = require('./task').Task,
99
shelljs = require('shelljs'),
1010
prompt = require('prompt'),
1111
IonicAppLib = require('ionic-app-lib'),
12-
IonicProject = IonicAppLib.project,
1312
IonicResources = IonicAppLib.resources,
1413
ConfigXml = IonicAppLib.configXml,
1514
Cordova = IonicAppLib.cordova,
1615
Hooks = IonicAppLib.hooks,
17-
Serve = IonicAppLib.serve,
1816
State = IonicAppLib.state,
1917
Utils = IonicAppLib.utils,
2018
Logging = IonicAppLib.logging;
@@ -30,6 +28,14 @@ IonicTask.prototype.run = function(ionic, argv) {
3028
appDirectory = process.cwd(),
3129
q;
3230

31+
if (argv.v2) {
32+
Serve = IonicAppLib.v2.serve;
33+
IonicProject = IonicAppLib.v2.project;
34+
} else {
35+
Serve = IonicAppLib.serve;
36+
IonicProject = IonicAppLib.project;
37+
}
38+
3339
try {
3440
// Patch - before doing a `ionic run ios`, we need to make sure they have that platform installed.
3541
// if not, try to install it.
@@ -128,6 +134,7 @@ IonicTask.prototype.run = function(ionic, argv) {
128134
.then(function(){
129135
// TODO :(
130136
if ( argv.v2 &&
137+
!self.isLiveReload &&
131138
!argv.b && !argv.nobundle &&
132139
(cmdName === 'build' || cmdName === 'emulate' || cmdName === 'run' || cmdName === 'upload'))
133140
{
@@ -367,7 +374,8 @@ IonicTask.prototype.setupLiveReload = function(argv) {
367374
var project = null;
368375

369376
try {
370-
project = IonicProject.load(process.cwd());
377+
var cwd = process.cwd();
378+
project = argv.v2 ? IonicProject.loadConfig(cwd) : IonicProject.load(cwd);
371379
} catch (ex) {
372380
console.log('Error occured', ex);
373381
return Utils.fail(ex.message);
@@ -415,6 +423,9 @@ IonicTask.prototype.setupLiveReload = function(argv) {
415423
}).then(function(){
416424
d.resolve();
417425
});
426+
if (argv.v2) {
427+
options.config = project.get();
428+
}
418429
return Serve.start(options);
419430
})
420431
.then(function() {

0 commit comments

Comments
 (0)