add the support for cordova-plugin-code-push#420
Conversation
…se & decorate them with Cordova decorator
| import {Vibration} from './plugins/vibration'; | ||
| import {VideoPlayer} from './plugins/video-player'; | ||
| import {WebIntent} from './plugins/webintent'; | ||
| import {CodePush} from './plugins/code-push'; |
There was a problem hiding this comment.
import/export statements are arranged by alphabetical order, please move this and the rest of the import/export statement to the appropriate place
|
Hey @ksachdeva Thanks for the awesome work here Please review the comments I left on the code and then we can get this merged |
|
Thanks Ibrahim. I will incorporate these suggestions shorty and resubmit |
|
Hi Ibrahim, I have taken care of all the suggestions from you. Am in the middle of creating an example (most likely in next hour or 2) on github to show the usage. Let me know if some more changes are required to accept the request. Regards & thanks |
|
Hi Ibrahim, There is now a full sample project at https://github.com/ksachdeva/ionic2-code-push-example I am facing a strange zoning issue. My understanding is that the observable fired by ionic-native would run in ngZone by default. Seems not to be the case (some times). See the RootPage.ts file for the example and comments. Regards |
| } | ||
| } | ||
|
|
||
| interface Window { |
There was a problem hiding this comment.
replace this with declare var window: any;
|
Sorry for the late response. All looks good now, except the 2 comments I left (minor things). Also if you could merge with the latest master branch to resolve the issues, that would be great. As for the observable issue, I don't see anything wrong with your code, I guess we can merge for now and investigate any problems later on. |
# Conflicts: # src/index.ts
… needed IWindow interface declaration
|
incorporated the changes. please accept as merging takes lot of time because my changes touch index.ts file Regards & thanks |
|
thanks @ksachdeva !! |
2 participants
No description provided.