-
Notifications
You must be signed in to change notification settings - Fork 51
Closed
Labels
enhancementNew feature or requestNew feature or request
Description
Problem
Currently, our pre-commit hooks only enforce linting and formatting. This allows commits that break the build or fail tests to be pushed to the repository, causing wasted time and effort for the team.
Proposed Solution
Enhance the pre-commit hooks to:
- Run
pnpm build
to ensure the project builds successfully - Run
pnpm test
to ensure all tests pass
This will prevent commits that would break the build or fail tests, improving code quality and reducing wasted time.
Implementation Details
- Update the pre-commit hook to run both
pnpm build
andpnpm test
in addition to the existing lint-staged checks - Ensure the hook provides clear error messages when checks fail
- Document the changes in the PR
Benefits
- Prevents broken code from being committed
- Saves time by catching issues earlier in the development process
- Ensures higher quality code in the repository
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request