fix: Prevent the client from un-escaping the encoded path parameters only for github #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
shivamnegi94
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic to prevent the client from unescaping the encoded GitHub path parameters when parsing the URL was causing issues with the URL in the case of the GitLab driver, specifically when the client is pointing to a GitLab Enterprise instance. The GitLab driver always encodes the repository path, which contains the account/project; therefore, this condition is always fulfilled.
By the comment, this logic was added only for the GitHub driver, and I've added that to the condition, so we check if the path contains %2F only in case of the GitHub driver