Skip to content

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Oct 7, 2016

No description provided.

@cclauss
Copy link
Contributor Author

cclauss commented Oct 7, 2016

Closed in favor of #673

@cclauss cclauss closed this Oct 7, 2016
@cclauss cclauss reopened this Oct 20, 2016
@cclauss cclauss changed the title pymavlink==2.0.8 pymavlink==2.1.0 Apr 18, 2017
@cclauss cclauss changed the title pymavlink==2.1.0 pymavlink==2.2.2 Apr 19, 2017
@peterbarker
Copy link
Contributor

@cclauss @sanderux I've changed the requirements.txt away from a strict requirement of 2.0.6 to >= 2.0.6

I'm not sure why the requirement was so strict in the first place. Some rather evil things had to be done because of that strict requirement when upstream removed 2.0.6....

@cclauss Why are you bumping the other package versions in this PR?

@mrpollo
Copy link
Member

mrpollo commented Apr 21, 2017

just double checked, I installed today and i got 2.2.0 we should be fine

cclauss added 2 commits April 22, 2017 03:58
Sync with `pymavlink>=2.0.6`
 Thanks @mrpollo for your confirmation.  On the other two:
* `future` [aligns with upstream](https://github.com/ArduPilot/pymavlink/blob/0e949ae41c0db266c8a903a5bcc8d6d7e1bb5c20/requirements.txt#L2) leveraging the [good work](http://python-future.org/whatsnew.html#what-s-new-in-version-0-16-0-2016-10-27) that team is doing to iron out issues with running 2 and 3 together.
* `monotonic` brings us [timing support for AIX](https://github.com/atdt/monotonic/releases/tag/1.3) which is an [important platform](http://www-03.ibm.com/press/us/en/pressrelease/50688.wss) for my organization.
@cclauss
Copy link
Contributor Author

cclauss commented Apr 22, 2017

Thanks @mrpollo for your confirmation. On the other two:

@sanderux
Copy link
Contributor

for px4 support, could we get pymavlink >= 2.2.2 ?

@peterbarker
Copy link
Contributor

Any reason not to >= for the monotonic support?

double-take on the AIX support.

@peterbarker
Copy link
Contributor

@sanderux I'm a bit concerned about pypi and versions getting installed. So... why did @mrpollo get 2.2.0 instead of 2.2.2, for example? Would not pay to break Ramon's laptop.

I think we should definitely move the requirement forward soon (PX4 being being a supported autopilot and all...), but I'd like to hear people naturally getting the requirement before we make that change.

If someone on MacOSX could pip search pymavlink, and someone on Windows pip search pymavlink and confirm that LATEST is 2.2.2, I think we could then move forward.

@sanderux
Copy link
Contributor

I think tridge might have released 2.2.0 as he mentioned to me he did. Perhaps 2.2.2 followed soon after.

Having the 2.2 requirement seems logical when people update dronekit. We could maybe ask tridge what the status is?

@cclauss
Copy link
Contributor Author

cclauss commented Apr 22, 2017

Looking at the commit messages, it appears that the bump of version numbers is the only difference between 2.2.0, 2.2.1, and 2.2.2. And I quote "darn pypi server isn't taking the uploads. 3rd try".

I am fine with making the change to >= for monotonic support

@peterbarker
Copy link
Contributor

I've squished all these together and pushed them in - thanks!

@cclauss You have a fair point on those versions, but it still bothers me that some people aren't seeing recent versions of pymavlink. If we start absolutely requiring those we may break things unnecessarily (new installs should work with PX4).

@cclauss cclauss deleted the patch-3 branch April 22, 2017 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants