Skip to content

Add route versioning support to transport module of Python SDK #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 26, 2018
Merged

Add route versioning support to transport module of Python SDK #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16d1208
Add route version to transport code on client side.
starforever Jun 22, 2018
128f49c
Added tests for invoking versioned routes.
starforever Jun 22, 2018
dd5436a
Fixed lint tests
starforever Jun 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions dropbox/dropbox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,8 @@ def request(self,
"""
host = route.attrs['host'] or 'api'
route_name = namespace + '/' + route.name
if route.version > 1:
route_name += '_v{}'.format(route.version)
route_style = route.attrs['style'] or 'rpc'
serialized_arg = stone_serializers.json_encode(route.arg_type,
request_arg)
Expand Down
12 changes: 12 additions & 0 deletions test/test_dropbox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
PathRootError,
)
from dropbox.files import (
DeleteResult,
ListFolderError,
)
from dropbox.common import (
Expand Down Expand Up @@ -191,6 +192,17 @@ def test_path_root_err(self, dbx):
dbxpr.files_list_folder('')
self.assertTrue(cm.exception.error.is_invalid_root())

@dbx_from_env
def test_versioned_route(self, dbx):
# Upload a test file
path = '/test.txt'
dbx.files_upload(DUMMY_PAYLOAD, path)

# Delete the file with v2 route
resp = dbx.files_delete_v2(path)
# Verify response type is of v2 route
self.assertIsInstance(resp, DeleteResult)

class TestDropboxTeam(unittest.TestCase):
@dbx_team_from_env
def test_team(self, dbxt):
Expand Down