Skip to content

Conversation

@rogebrd
Copy link
Contributor

@rogebrd rogebrd commented Aug 27, 2020

  • Remove Stone as submodule and pin in requirements.txt
  • Pin Stone to major version 1.* until work can be done to upgrade to 2.*
  • Update Spec

Files Namespace

Add internal_error to SearchError union.
Add locked to LookupError union.
Add cant_move_into_vault to RelocationError union.
Add MoveIntoVaultError union.
Add SearchMatchFieldOptions struct.
Add optional match_field_options to SearchV2Arg struct.
Doc/example changes.
Sharing Namespace

Add is_vault to SharePathError union.
Add invalid_shared_folder to AddFolderMemberError union.
Team Namespace

Make members field of LegalHoldsPolicyUpdateArg struct optional.
Add app_folder_removal_not_supported to RevokeLinkedAppError union.
Doc/example changes.
Team Log Namespace

Add auto_approve to InviteMethod union.
Add moved_from_another_team to InviteMethod union.
Add moved_from_another_team to MemberStatus union.
Add no_one to SharedLinkVisibility union.
Add optional new_team to MemberChangeStatusDetails struct.
Add optional previous_team to MemberChangeStatusDetails struct.
Add external_sharing_create_report_details to EventDetails union.
Add external_sharing_report_failed to EventDetails union.
Add content_administration_policy_changed_details to EventDetails
Add external_sharing_create_report to EventType.
Add external_sharing_report_failed to EventType.
Add content_administration_policy_changed to EventType.
union.
Add send_for_signature_policy_changed_details to EventDetails union.
Add external_sharing_create_report to EventTypeArgs union.
Add external_sharing_report_failed to EventTypeArgs union.
Add content_administration_policy_changed to EventTypeArgs union.
Add send_for_signature_policy_changed to EventTypeArgs union.
Add SendForSignaturePolicy union.
Add ExternalSharingCreateReportDetails struct.
Add ExternalSharingReportFailedDetails struct.
Add ContentAdministrationPolicyChangedDetails struct.
Add SendForSignaturePolicyChangedDetails struct.
Add ExternalSharingCreateReportType struct.
Add ExternalSharingReportFailedType struct.
Add ContentAdministrationPolicyChangedType struct.
Add SendForSignaturePolicyChangedType struct.

- Remove Stone as submodule and pin in requirements.txt
- Pin Stone to major version 1.* until work can be done to upgrade to 2.*
- Update Spec

Files Namespace

Add internal_error to SearchError union.
Add locked to LookupError union.
Add cant_move_into_vault to RelocationError union.
Add MoveIntoVaultError union.
Add SearchMatchFieldOptions struct.
Add optional match_field_options to SearchV2Arg struct.
Doc/example changes.
Sharing Namespace

Add is_vault to SharePathError union.
Add invalid_shared_folder to AddFolderMemberError union.
Team Namespace

Make members field of LegalHoldsPolicyUpdateArg struct optional.
Add app_folder_removal_not_supported to RevokeLinkedAppError union.
Doc/example changes.
Team Log Namespace

Add auto_approve to InviteMethod union.
Add moved_from_another_team to InviteMethod union.
Add moved_from_another_team to MemberStatus union.
Add no_one to SharedLinkVisibility union.
Add optional new_team to MemberChangeStatusDetails struct.
Add optional previous_team to MemberChangeStatusDetails struct.
Add external_sharing_create_report_details to EventDetails union.
Add external_sharing_report_failed to EventDetails union.
Add content_administration_policy_changed_details to EventDetails
Add external_sharing_create_report to EventType.
Add external_sharing_report_failed to EventType.
Add content_administration_policy_changed to EventType.
union.
Add send_for_signature_policy_changed_details to EventDetails union.
Add external_sharing_create_report to EventTypeArgs union.
Add external_sharing_report_failed to EventTypeArgs union.
Add content_administration_policy_changed to EventTypeArgs union.
Add send_for_signature_policy_changed to EventTypeArgs union.
Add SendForSignaturePolicy union.
Add ExternalSharingCreateReportDetails struct.
Add ExternalSharingReportFailedDetails struct.
Add ContentAdministrationPolicyChangedDetails struct.
Add SendForSignaturePolicyChangedDetails struct.
Add ExternalSharingCreateReportType struct.
Add ExternalSharingReportFailedType struct.
Add ContentAdministrationPolicyChangedType struct.
Add SendForSignaturePolicyChangedType struct.
@rogebrd rogebrd requested a review from emmaworley August 27, 2020 21:10
Copy link
Contributor

@emmaworley emmaworley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rogebrd rogebrd merged commit 5ef1a2a into master Aug 27, 2020
@rogebrd rogebrd deleted the remove_stone_submodule branch August 27, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants