Update typings to be more precise #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilevkivskyi
approved these changes
Dec 18, 2018
Contributor
ilevkivskyi
left a comment
ilevkivskyi
left a comment
There was a problem hiding this comment.
This doesn't cause any significant issues in our codebases, so I think this is good to go.
Btw, do I need to update any checkboxes in #3?
| primary_key: bool = ... | ||
| foreign_keys: List[ForeignKey] = ... | ||
| key: Optional[str] = ... | ||
| def self_group(self: _CE, against: Optional[Any] = ...) -> Union[AsBoolean, Grouping[_T], _CE]: ... |
Contributor
There was a problem hiding this comment.
Normally we try to avoid such unions in return types. But this one is probably OK.
| def scalar(self) -> Any: ... # type: ignore # incompatible with Executable.scalar | ||
| def execute(self) -> ResultProxy: ... # type: ignore # incompatible with Executable.execute | ||
| def self_group(self, against: Optional[Any] = ...) -> Union[ColumnElement[_T], Grouping[_T]]: ... | ||
| def self_group(self: _FE, against: Optional[Any] = ...) -> Union[AsBoolean, Grouping[_T], _FE]: ... |
Contributor
There was a problem hiding this comment.
Same comment about union return here. If people will complain, then we can replace this with Any.
Contributor
Author
|
Yeah, you can check the ones for |
Contributor
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.