In this file Sequence is not typing.Sequence

[euresti]

Hi. I started testing this against our codebase and noticed some errors.

[ilevkivskyi]

Thanks for PR! It looks indeed like an oversight, @bryanforbes could you please double-check?

[ilevkivskyi]

Btw, @euresti it would be great if you could add a test or couple for this (e.g. just a model with one foreign key constraint that accepts a list of columns). Note: our test cases aren't run, just type-checked with mypy (they are very similar to mypy's test suite).

[bryanforbes]

Yes, this was an oversight on my part. Good find @euresti!

@ilevkivskyi does he need to sign a CLA?

[ilevkivskyi]

Oh, yes, indeed I completely forgot about CLA, @euresti could you please sign it?

[euresti]

Done!

[ilevkivskyi]

Thanks for signing CLA! Are you going to add the test as I suggested above? (If not, I will merge this anyway, but it is always better with a test.)

[euresti]

I'll look into a test. I was testing this on our code base and found a couple of other issues with the stubs. I'll file Issues for those since I'm not sure what the correct solution to some of those are.

[euresti]

Test has been added.

[ilevkivskyi]

Thanks!

[ilevkivskyi]

I was testing this on our code base and found a couple of other issues with the stubs. I'll file Issues for those since I'm not sure what the correct solution to some of those are.

OK, sure.