Skip to content

Conversation

@isra17
Copy link
Contributor

@isra17 isra17 commented Aug 28, 2019

Quick fix that allow support for:

# From official doc
from sqlalchemy import text

Table("sometable", metadata,
                Column("name", String(50)),
                Column("address", String(100)),
                Index("some_index", text("lower(name)"))
        )

@isra17 isra17 force-pushed the fix-index-init branch 2 times, most recently from 9dd15c7 to b7aca4c Compare August 28, 2019 18:56
Copy link
Contributor

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have just one question.

Could you please also add a test case for this (e.g. the one you mention in the PR description)? The test cases live in test/test-data in .test files.

@isra17
Copy link
Contributor Author

isra17 commented Aug 29, 2019

Could you please also add a test case for this (e.g. the one you mention in the PR description)? The test cases live in test/test-data in .test files.

Done

Copy link
Contributor

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ilevkivskyi ilevkivskyi merged commit 009f824 into dropbox:master Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants