Remove obsolete ddev plugins#58
Merged
Merged
Conversation
tannerjfco
approved these changes
Mar 10, 2017
tannerjfco
left a comment
Contributor
There was a problem hiding this comment.
Code changes all look good here. I manually tested all commands and they seem to work as expected.
Member
Author
|
Added manual testing instructions. |
This was referenced Mar 14, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem:
We are abandoning all plugins except the plugin formerly known as 'local' at this time. This removes them.
The Fix:
Remove them, change names, remove newmedia, temporarily disengage tests by renaming the files.
Related Issue Link(s):
Remove legacy and drudapi plugins
Release/Deployment notes:
Does this affect anything else, or are there ramifications for other code? Does anything have to be done on deployment?
Several TODOs are in the code -
Code Review
This is hard to review so I split it into 3 commits.
Manual Testing
The "-p local" argument is no longer necessary with this PR. That's the only platform plugin remaining and it's the default.
The split of "add" into "start" and "import" is not in this PR, so this uses the traditional "add" subcommand.
ddev add <sitename> <environment>(fails, but creates dirs in ~/.drud/local). Example:ddev add drud-d8 production<environment>-<sitename>.tar.gzddev add <sitename> <environment, Example:ddev add drud-d8 production(should work this time)