Fix hydration issues and warnings on non-error pages. #14
Conversation
Codecov Report
@@ Coverage Diff @@
## 1.x #14 +/- ##
=======================================
Coverage 96.00% 96.00%
=======================================
Files 1 1
Lines 25 25
Branches 8 8
=======================================
Hits 24 24
Misses 1 1 Continue to review full report at Codecov.
|
fago
force-pushed
the
feature/fix-hydration
branch
from
1ff9379 to
bf94abb
Compare
fago
force-pushed
the
feature/fix-hydration
branch
from
8b0816f to
471707b
Compare
… .statusCode property.
| /** | ||
| * Returns an object for rendering as Vue component. | ||
| */ | ||
| this.$currentPage.contentComponent = () => { |
There was a problem hiding this comment.
this one main reason for the warnings (it'S not able to serialize this)
| // Request made and server responded. If we get a proper Drupal error | ||
| // page, apply it and propagate the error code. | ||
| if (error.response.data && error.response.data.title && error.response.data.content) { | ||
| this.processPageResponse(error.response.data, error.response.status) |
There was a problem hiding this comment.
this takes over drupal error pages if possibles - nothing special todo then to make them apply.
if necessary statusCode property is there in case the frontend wants to differentiate. It won't trigger nuxt error handling and default nuxt error pages. So we can have two level of error handling:
- regular 403/404 pages, cms controlled
- nuxt errors, solely frontend controlled.
No description provided.