fix: LDP-2307: remove locks for nodes to be deleted by drush testCleanup. #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fago
approved these changes
Nov 14, 2023
Contributor
|
Makes sense to me. |
petarbasic
approved these changes
Nov 14, 2023
Contributor
|
Good improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is convenient for cleanup commands on websites with the content_lock module enabled.
(
It's especially inconvenient that if content is still locked when this command runs,
content_lock_entity_predelete()does not warn or log any message; instead it does a hard redirect -which outputs a HTML response to STDOUT- andexit(0). This confusing behavior can be an extra incentive for people to just not clean up after tests. (https://www.drupal.org/project/content_lock/issues/2951652)But that's a side note; this drush command should probably unlock and remove the content anyway, regardless whether that issue gets fixed.
)