Issue #2762995 by mglaman, dylanf: Add a description/message field #450
Conversation
mglaman
force-pushed
the
2762995-promotion-description-field
branch
from
bfe90c6 to
6403932
Compare
|
|
||
| $fields['description'] = BaseFieldDefinition::create('string_long') | ||
| ->setLabel(t('Description')) | ||
| ->setDescription(t('The description of the promotion. This is additional information, beyond the name, which can be displayed to the customer.')) |
There was a problem hiding this comment.
@bojanz description look "good enough"?
There was a problem hiding this comment.
"The description of the promotion." is redundant, it doesn't say anything that the "Description" field name doesn't already say. We remove that, it leaves us with "This is additional information, beyond the name, which can be displayed to the customer.". Maybe we can reword that as "Used to describe the promotion to the customer."? Let's bikeshed on IRC.
There was a problem hiding this comment.
So Woo, Spree, etc don't have a helper label. "Additional information about the promotion to show to the customer"
|
I think this looks great. |
@bojanz ^ yeah? |
mglaman
force-pushed
the
discount
branch
2 times, most recently
from
a0e750b to
16a495d
Compare
mglaman
force-pushed
the
2762995-promotion-description-field
branch
from
6403932 to
b3eded0
Compare
|
Per @bojanz disccusion "Additional information about the promotion to show to the customer" |
3 participants
No description provided.